Conversation
entities/signin, features/signin 디렉토리를 sign-in으로 리네이밍하고 관련 import 경로를 업데이트합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
searchparams.ts를 search-params.ts로 리네이밍하고 index.ts의 export 경로와 모듈 JSDoc을 업데이트합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BigtabletLink, BigtabletNavigation, BigtabletParams, BigtabletPathname, BigtabletRouter 훅에 JSDoc 주석을 추가합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
api/axios, api/cookie, api/gcp, ui/date, ui/portal, ui/scroll, ui/text 유틸리티 함수 및 훅에 JSDoc 주석을 추가합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
에러 파싱 및 에러 메시지 스키마 유틸리티에 JSDoc 주석을 추가합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
App → HomePage 리네이밍, 환영 페이지 콘텐츠 추가, RootLayout에 JSDoc 주석을 추가합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
탭 인덴트를 스페이스로 통일합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
refactor: apply kebab-case naming and JSDoc conventions to templates
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 코드베이스 전반의 일관성과 유지보수성을 향상시키는 데 중점을 둡니다. 주요 변경 사항으로는 네이밍 컨벤션을 kebab-case로 통일하고, 핵심 유틸리티 및 컴포넌트에 상세한 JSDoc 주석을 추가하여 문서화를 강화했습니다. 또한, 애플리케이션의 초기 진입점 페이지를 개선하고, Shadcn 템플릿의 로그인 페이지 코드 스타일을 정돈하여 개발 경험과 코드 품질을 높였습니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
@clack/prompts 0.9→1.1, @commitlint 19→20, @types/node 24→25, semantic-release, tsup, typescript 등 최신 버전으로 업그레이드합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
next 16.1.5→16.2.0, @bigtablet/design-system 1.18→1.22, biome 2.3→2.4, zod 4.1→4.3, sass, axios, zustand 등 최신 버전으로 업그레이드합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
next 16.1.5→16.2.0, biome 2.3→2.4, lucide-react 0.552→0.577, tailwind-merge 3.0→3.5, zod, axios, zustand 등 최신 버전으로 업그레이드합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request primarily focuses on refactoring authentication-related code, including renaming signin modules to sign-in for consistency across design-system and shadcn templates, and introducing new API, constants, and mutation files for sign-in functionality. It also enhances the useSignin hook by implementing robust URL validation to prevent open redirect vulnerabilities and refactors its mutation logic. Additionally, the changes include adding comprehensive JSDoc comments to various components, hooks, and utilities, improving error handling in the GCP upload API to throw errors for invalid responses, and refining the formatRelative date utility with named constants. Review comments suggest further improvements to the redirect URL validation logic in the useSignin hook, recommend replacing inline styles with CSS modules for better maintainability, and advise removing a redundant async wrapper in the useSigninMutation's mutationFn.
templates/design-system/src/features/sign-in/model/sign-in.hook.ts
Outdated
Show resolved
Hide resolved
templates/design-system/src/features/sign-in/mutation/sign-in.mutation.ts
Outdated
Show resolved
Hide resolved
config/upgrade-dependencies
- consolidate redirect validation logic in design-system sign-in hook - use startsWith instead of includes for redirect validation in shadcn - replace inline styles with CSS module in design-system home page - remove redundant async wrapper in design-system signin mutation - throw error instead of returning empty string in gcp upload api Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
deploy.yml에서 하드코딩된 pnpm@9를 제거하고 packageManager 필드를 참조하도록 변경합니다. packageManager를 pnpm@10.32.0으로 고정합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@clack/prompts 1.x에서 validate 콜백의 value 타입이 string | undefined로 변경되어 기본값을 할당합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 participant
제목
merge: release develop
작업한 내용
signin→sign-in,searchparams→search-paramskebab-case 리네이밍전달할 추가 이슈